Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UMD, package.json, and proper deinitialization #11

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

UMD, package.json, and proper deinitialization #11

wants to merge 3 commits into from

Conversation

futpib
Copy link

@futpib futpib commented Mar 30, 2017 •
edited
Loading

Motivations:

  • UMD - kinda obvious
    • Needed to use this plugin in CommonJS environment
  • package.json
    • Browserify can not load a module without package.json (I expect the same is true for webpack)
  • deinitialization, event namespacing and unbinding
    • When datatable is destroyed, rowsGroup failed to unbind it's event, and, if later you instantiate datable on the same DOM element, you get double event handling from both old and new rowsGroup instances

@futpib futpib changed the title package.json and UMD UMD, package.json, and proper deinitialization Mar 31, 2017
@ashl1
Copy link
Owner

ashl1 commented Aug 26, 2017

Argh... Only see you've already do this.
Thank with this. I want to rewrite it with ES6 and publish at npm.

@flying-sheep flying-sheep mentioned this pull request Sep 7, 2017
Open
@jellylamp jellylamp mentioned this pull request Jun 22, 2018
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@futpib @ashl1